Adam Armstrong adama@memetic.org wrote:
On 2013-08-30 19:00, Rob J. Epping wrote:
Hi
On Fri, Aug 30, 2013 at 4:48 PM, Adam Armstrong adama@memetic.org wrote:
php -l config.php
That made me run the following shell one-liner.
for x in `find -name ".svn" -prune -o -type f -name "*php*" -print`; do php -l $x; done | grep -v "^No syntax errors detected in "
The result (including patch) is in http://jira.observium.org/browse/OBSERVIUM-474
Haha. Most of those files are no longer used, or are contributed applications.
I notice that the postgresql application is completely broken, even after the fix (using polled value to set DS name?!). It's fixed now!
Like I said before, I ran php lint (php -l) on all php files and fixed the errors lint showed an only those. Did not look into more detail than that.
Recently I had a look at check in validation for svn. Running a lint check as check in validation would prevent these errors from being in svn.
adam.
GRTNX, RobJE