Print Interface Details - show other devices in the same subnet - need to exclude the private IP addresses ?
Hi All,
I have a small suggestion regarding the info displayed together with each interface under 'Port' => 'Detail' .
There we noticed the observium displays all other devices on the same subnet from other devices at the last column of each interface irrespective of whether they are real IPs ( internet routable ) or Private IP addresses ( defined in RFC 1918 ).
Although this feature is really good, we feel that if there is an option to exclude certain IP subnets from this selection, specially the private IP addresses it would make sense because we found there are lot of unrelated interfaces are getting listed ( about 50 items ) under this merely because of the fact that they are having the same IP addresses/subnets but which are completely different and isolated device interfaces in other VPNs which is common in IP VPN setups.
We found the location where this logic is programmed, and we can easily changed the SQL query to accommodate this as follows ( *`ipv4_address` NOT LIKE '192.168.% etc. ) *shown below
But it would be elegant if these excluding subnets could be defined as a config parameter and filter them here.
This is just a suggestion, there may be better ideas out there with you guys
What do you all think ?
/opt/observium/html/includes/print-interface.inc.php :
if ($port_details) { // *Show which other devices are on the same subnet as this interface* foreach (dbFetchRows("SELECT `ipv4_network_id` FROM `ipv4_addresses` WHERE `port_id` = ? AND `ipv4_address` NOT LIKE '127.%' *AND `ipv4_address` NOT LIKE '192.168.%*'", array($port['port_id'])) as $net) { $sql = "SELECT N.*, P.`port_id`, P.`device_id` FROM `ipv4_addresses` AS A, `ipv4_networks` AS N, `ports` AS P WHERE A.`port_id` = P.`port_id` AND P.`device_id` != ? AND A.`ipv4_network_id` = ? AND N.`ipv4_network_id` = A.`ipv4_network_id` AND P.`ifAdminStatus` = 'up'";
$params = array($device['device_id'], $net['ipv4_network_id']);
foreach (dbFetchRows($sql, $params) AS $new) { if ($cache['devices']['id'][$new['device_id']]['disabled'] && !$config['web_show_disabled']) { continue; } $int_links[$new['port_id']] = $new['port_id']; $int_links_v4[$new['port_id']][] = $new['ipv4_network']; } }
Hi All,
Please find the annexed screenshot of part of the interface, depicting this case.
With Best Regards,
Supun Rathnayake
Lanka communication Services (Pvt) Ltd. 65C, Dharmapala Mawatha, Colombo 07. Sri Lanka. Tel: +94-11-2437545 http://www.lankacom.net http://blog.lankacom.net
On 01/06/2014 06:35 PM, Supun Rathnayake wrote:
Hi All,
I have a small suggestion regarding the info displayed together with each interface under 'Port' => 'Detail' .
There we noticed the observium displays all other devices on the same subnet from other devices at the last column of each interface irrespective of whether they are real IPs ( internet routable ) or Private IP addresses ( defined in RFC 1918 ).
Although this feature is really good, we feel that if there is an option to exclude certain IP subnets from this selection, specially the private IP addresses it would make sense because we found there are lot of unrelated interfaces are getting listed ( about 50 items ) under this merely because of the fact that they are having the same IP addresses/subnets but which are completely different and isolated device interfaces in other VPNs which is common in IP VPN setups.
We found the location where this logic is programmed, and we can easily changed the SQL query to accommodate this as follows ( *`ipv4_address` NOT LIKE '192.168.% etc. ) *shown below
But it would be elegant if these excluding subnets could be defined as a config parameter and filter them here.
This is just a suggestion, there may be better ideas out there with you guys
What do you all think ?
/opt/observium/html/includes/print-interface.inc.php :
if ($port_details) { // *Show which other devices are on the same subnet as this interface* foreach (dbFetchRows("SELECT `ipv4_network_id` FROM `ipv4_addresses` WHERE `port_id` = ? AND `ipv4_address` NOT LIKE '127.%' *AND `ipv4_address` NOT LIKE '192.168.%*'", array($port['port_id'])) as $net) { $sql = "SELECT N.*, P.`port_id`, P.`device_id` FROM `ipv4_addresses` AS A, `ipv4_networks` AS N, `ports` AS P WHERE A.`port_id` = P.`port_id` AND P.`device_id` != ? AND A.`ipv4_network_id` = ? AND N.`ipv4_network_id` = A.`ipv4_network_id` AND P.`ifAdminStatus` = 'up'";
$params = array($device['device_id'], $net['ipv4_network_id']); foreach (dbFetchRows($sql, $params) AS $new) { if ($cache['devices']['id'][$new['device_id']]['disabled'] &&!$config['web_show_disabled']) { continue; } $int_links[$new['port_id']] = $new['port_id']; $int_links_v4[$new['port_id']][] = $new['ipv4_network']; } }
-- With Best Regards,
Supun Rathnayake
Lanka communication Services (Pvt) Ltd. 65C, Dharmapala Mawatha, Colombo 07. Sri Lanka. Tel: +94-11-2437545 http://www.lankacom.net http://blog.lankacom.net
observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
Hi,
I think we would prefer to do something like "connected to 21 devices" with a mouseover popup containing the list, when there are more than 5 or so devices.
adam.
On 2014-01-07 10:12, Supun Rathnayake wrote:
Hi All,
Please find the annexed screenshot of part of the interface, depicting this case.
With Best Regards,
Supun Rathnayake
Lanka communication Services (Pvt) Ltd. 65C, Dharmapala Mawatha, Colombo 07. Sri Lanka. Tel: +94-11-2437545 http://www.lankacom.net [1] http://blog.lankacom.net [2]
On 01/06/2014 06:35 PM, Supun Rathnayake wrote:
Hi All,
I have a small suggestion regarding the info displayed together with each interface under 'Port' => 'Detail' .
There we noticed the observium displays all other devices on the same subnet from other devices at the last column of each interface irrespective of whether they are real IPs ( internet routable ) or Private IP addresses ( defined in RFC 1918 ).
Although this feature is really good, we feel that if there is an option to exclude certain IP subnets from this selection, specially the private IP addresses it would make sense because we found there are lot of unrelated interfaces are getting listed ( about 50 items ) under this merely because of the fact that they are having the same IP addresses/subnets but which are completely different and isolated device interfaces in other VPNs which is common in IP VPN setups.
We found the location where this logic is programmed, and we can easily changed the SQL query to accommodate this as follows ( `IPV4_ADDRESS` NOT LIKE '192.168.% ETC. ) shown below
But it would be elegant if these excluding subnets could be defined as a config parameter and filter them here.
This is just a suggestion, there may be better ideas out there with you guys
What do you all think ?
/opt/observium/html/includes/print-interface.inc.php :
if ($port_details) { // SHOW WHICH OTHER DEVICES ARE ON THE SAME SUBNET AS THIS INTERFACE foreach (dbFetchRows("SELECT `ipv4_network_id` FROM `ipv4_addresses` WHERE `port_id` = ? AND `ipv4_address` NOT LIKE '127.%' AND `IPV4_ADDRESS` NOT LIKE '192.168.%'", array($port['port_id'])) as $net) { $sql = "SELECT N.*, P.`port_id`, P.`device_id` FROM `ipv4_addresses` AS A, `ipv4_networks` AS N, `ports` AS P WHERE A.`port_id` = P.`port_id` AND P.`device_id` != ? AND A.`ipv4_network_id` = ? AND N.`ipv4_network_id` = A.`ipv4_network_id` AND P.`ifAdminStatus` = 'up'";
$params = array($device['device_id'], $net['ipv4_network_id']);
foreach (dbFetchRows($sql, $params) AS $new) { if ($cache['devices']['id'][$new['device_id']]['disabled'] && !$config['web_show_disabled']) { continue; } $int_links[$new['port_id']] = $new['port_id']; $int_links_v4[$new['port_id']][] = $new['ipv4_network']; } }
-- With Best Regards,
Supun Rathnayake
Lanka communication Services (Pvt) Ltd. 65C, Dharmapala Mawatha, Colombo 07. Sri Lanka. Tel: +94-11-2437545 http://www.lankacom.net [1] http://blog.lankacom.net [2]
observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium [3]
Links:
[1] http://www.lankacom.net [2] http://blog.lankacom.net [3] http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
Hi Adam,
That idea also makes sense.
With Best Regards,
Supun Rathnayake
Lanka communication Services (Pvt) Ltd. 65C, Dharmapala Mawatha, Colombo 07. Sri Lanka. Tel: +94-11-2437545 http://www.lankacom.net http://blog.lankacom.net
On 01/07/2014 04:55 PM, Adam Armstrong wrote:
Hi,
I think we would prefer to do something like "connected to 21 devices" with a mouseover popup containing the list, when there are more than 5 or so devices.
adam.
On 2014-01-07 10:12, Supun Rathnayake wrote:
Hi All,
Please find the annexed screenshot of part of the interface, depicting this case.
With Best Regards,
Supun Rathnayake
Lanka communication Services (Pvt) Ltd. 65C, Dharmapala Mawatha, Colombo 07. Sri Lanka. Tel: +94-11-2437545 http://www.lankacom.net [1] http://blog.lankacom.net [2]
On 01/06/2014 06:35 PM, Supun Rathnayake wrote:
Hi All,
I have a small suggestion regarding the info displayed together with each interface under 'Port' => 'Detail' .
There we noticed the observium displays all other devices on the same subnet from other devices at the last column of each interface irrespective of whether they are real IPs ( internet routable ) or Private IP addresses ( defined in RFC 1918 ).
Although this feature is really good, we feel that if there is an option to exclude certain IP subnets from this selection, specially the private IP addresses it would make sense because we found there are lot of unrelated interfaces are getting listed ( about 50 items ) under this merely because of the fact that they are having the same IP addresses/subnets but which are completely different and isolated device interfaces in other VPNs which is common in IP VPN setups.
We found the location where this logic is programmed, and we can easily changed the SQL query to accommodate this as follows ( `IPV4_ADDRESS` NOT LIKE '192.168.% ETC. ) shown below
But it would be elegant if these excluding subnets could be defined as a config parameter and filter them here.
This is just a suggestion, there may be better ideas out there with you guys
What do you all think ?
/opt/observium/html/includes/print-interface.inc.php :
if ($port_details) { // SHOW WHICH OTHER DEVICES ARE ON THE SAME SUBNET AS THIS INTERFACE foreach (dbFetchRows("SELECT `ipv4_network_id` FROM `ipv4_addresses` WHERE `port_id` = ? AND `ipv4_address` NOT LIKE '127.%' AND `IPV4_ADDRESS` NOT LIKE '192.168.%'", array($port['port_id'])) as $net) { $sql = "SELECT N.*, P.`port_id`, P.`device_id` FROM `ipv4_addresses` AS A, `ipv4_networks` AS N, `ports` AS P WHERE A.`port_id` = P.`port_id` AND P.`device_id` != ? AND A.`ipv4_network_id` = ? AND N.`ipv4_network_id` = A.`ipv4_network_id` AND P.`ifAdminStatus` = 'up'";
$params = array($device['device_id'], $net['ipv4_network_id']);
foreach (dbFetchRows($sql, $params) AS $new) { if ($cache['devices']['id'][$new['device_id']]['disabled'] && !$config['web_show_disabled']) { continue; } $int_links[$new['port_id']] = $new['port_id']; $int_links_v4[$new['port_id']][] = $new['ipv4_network']; } }
-- With Best Regards,
Supun Rathnayake
Lanka communication Services (Pvt) Ltd. 65C, Dharmapala Mawatha, Colombo 07. Sri Lanka. Tel: +94-11-2437545 http://www.lankacom.net [1] http://blog.lankacom.net [2]
observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium [3]
Links:
[1] http://www.lankacom.net [2] http://blog.lankacom.net [3] http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
Hi,
yes, I was going to make this long ago. I will make this soon.
Mike.
On Tue, Jan 7, 2014 at 3:25 PM, Adam Armstrong adama@memetic.org wrote:
Hi,
I think we would prefer to do something like "connected to 21 devices" with a mouseover popup containing the list, when there are more than 5 or so devices.
adam.
On 2014-01-07 10:12, Supun Rathnayake wrote:
Hi All,
Please find the annexed screenshot of part of the interface, depicting this case.
With Best Regards,
Supun Rathnayake
Lanka communication Services (Pvt) Ltd. 65C, Dharmapala Mawatha, Colombo 07. Sri Lanka. Tel: +94-11-2437545 http://www.lankacom.net [1] http://blog.lankacom.net [2]
On 01/06/2014 06:35 PM, Supun Rathnayake wrote:
Hi All,
I have a small suggestion regarding the info displayed together with each interface under 'Port' => 'Detail' .
There we noticed the observium displays all other devices on the same subnet from other devices at the last column of each interface irrespective of whether they are real IPs ( internet routable ) or Private IP addresses ( defined in RFC 1918 ).
Although this feature is really good, we feel that if there is an option to exclude certain IP subnets from this selection, specially the private IP addresses it would make sense because we found there are lot of unrelated interfaces are getting listed ( about 50 items ) under this merely because of the fact that they are having the same IP addresses/subnets but which are completely different and isolated device interfaces in other VPNs which is common in IP VPN setups.
We found the location where this logic is programmed, and we can easily changed the SQL query to accommodate this as follows ( `IPV4_ADDRESS` NOT LIKE '192.168.% ETC. ) shown below
But it would be elegant if these excluding subnets could be defined as a config parameter and filter them here.
This is just a suggestion, there may be better ideas out there with you guys
What do you all think ?
/opt/observium/html/includes/print-interface.inc.php :
if ($port_details) { // SHOW WHICH OTHER DEVICES ARE ON THE SAME SUBNET AS THIS INTERFACE foreach (dbFetchRows("SELECT `ipv4_network_id` FROM `ipv4_addresses` WHERE `port_id` = ? AND `ipv4_address` NOT LIKE '127.%' AND `IPV4_ADDRESS` NOT LIKE '192.168.%'", array($port['port_id'])) as $net)
{ $sql = "SELECT N.*, P.`port_id`, P.`device_id` FROM `ipv4_addresses` AS A, `ipv4_networks` AS N, `ports` AS P WHERE A.`port_id` = P.`port_id` AND P.`device_id` != ? AND A.`ipv4_network_id` = ? AND N.`ipv4_network_id` = A.`ipv4_network_id` AND P.`ifAdminStatus` = 'up'";
$params = array($device['device_id'], $net['ipv4_network_id']);
foreach (dbFetchRows($sql, $params) AS $new) { if ($cache['devices']['id'][$new['device_id']]['disabled'] && !$config['web_show_disabled']) { continue; } $int_links[$new['port_id']] = $new['port_id']; $int_links_v4[$new['port_id']][] = $new['ipv4_network']; } }
-- With Best Regards,
Supun Rathnayake
Lanka communication Services (Pvt) Ltd. 65C, Dharmapala Mawatha, Colombo 07. Sri Lanka. Tel: +94-11-2437545 http://www.lankacom.net [1] http://blog.lankacom.net [2]
observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium [3]
Links:
[1] http://www.lankacom.net [2] http://blog.lankacom.net [3] http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
Hi All,
The recent svn update below (r5928) solved my earlier request made sometime back, Thanks a lot guys !!!
Author: sid3windr Date: 2014-11-02 01:01:14 +0100 (Sun, 02 Nov 2014) New Revision: 5928
Modified: observium/trunk/html/includes/functions.inc.php observium/trunk/html/includes/print-interface.inc.php observium/trunk/includes/dbFacile.php observium/trunk/includes/defaults.inc.php observium/trunk/includes/definitions.inc.php observium/trunk/includes/discovery/ipv6-addresses.inc.php observium/trunk/includes/functions.inc.php Log: Medium: add ignore_common_subnet option, which allows you to specify (exact) subnets that should not be considered for the 'other ports on same subnet' displayed in the port listing
With Best Regards,
Supun Rathnayake
Lanka communication Services (Pvt) Ltd. 65C, Dharmapala Mawatha, Colombo 07. Sri Lanka. Tel: +94-11-2437545 http://www.lankacom.net
On 01/09/2014 02:31 AM, Mike Stupalov wrote:
Hi,
yes, I was going to make this long ago. I will make this soon.
Mike.
On Tue, Jan 7, 2014 at 3:25 PM, Adam Armstrong <adama@memetic.org mailto:adama@memetic.org> wrote:
Hi, I think we would prefer to do something like "connected to 21 devices" with a mouseover popup containing the list, when there are more than 5 or so devices. adam. On 2014-01-07 10:12, Supun Rathnayake wrote: Hi All, Please find the annexed screenshot of part of the interface, depicting this case. With Best Regards, Supun Rathnayake Lanka communication Services (Pvt) Ltd. 65C, Dharmapala Mawatha, Colombo 07. Sri Lanka. Tel: +94-11-2437545 http://www.lankacom.net [1] http://blog.lankacom.net [2] On 01/06/2014 06:35 PM, Supun Rathnayake wrote: Hi All, I have a small suggestion regarding the info displayed together with each interface under 'Port' => 'Detail' . There we noticed the observium displays all other devices on the same subnet from other devices at the last column of each interface irrespective of whether they are real IPs ( internet routable ) or Private IP addresses ( defined in RFC 1918 ). Although this feature is really good, we feel that if there is an option to exclude certain IP subnets from this selection, specially the private IP addresses it would make sense because we found there are lot of unrelated interfaces are getting listed ( about 50 items ) under this merely because of the fact that they are having the same IP addresses/subnets but which are completely different and isolated device interfaces in other VPNs which is common in IP VPN setups. We found the location where this logic is programmed, and we can easily changed the SQL query to accommodate this as follows ( `IPV4_ADDRESS` NOT LIKE '192.168.% ETC. ) shown below But it would be elegant if these excluding subnets could be defined as a config parameter and filter them here. This is just a suggestion, there may be better ideas out there with you guys What do you all think ? /opt/observium/html/includes/print-interface.inc.php : if ($port_details) { // SHOW WHICH OTHER DEVICES ARE ON THE SAME SUBNET AS THIS INTERFACE foreach (dbFetchRows("SELECT `ipv4_network_id` FROM `ipv4_addresses` WHERE `port_id` = ? AND `ipv4_address` NOT LIKE '127.%' AND `IPV4_ADDRESS` NOT LIKE '192.168.%'", array($port['port_id'])) as $net) { $sql = "SELECT N.*, P.`port_id`, P.`device_id` FROM `ipv4_addresses` AS A, `ipv4_networks` AS N, `ports` AS P WHERE A.`port_id` = P.`port_id` AND P.`device_id` != ? AND A.`ipv4_network_id` = ? AND N.`ipv4_network_id` = A.`ipv4_network_id` AND P.`ifAdminStatus` = 'up'"; $params = array($device['device_id'], $net['ipv4_network_id']); foreach (dbFetchRows($sql, $params) AS $new) { if ($cache['devices']['id'][$new['device_id']]['disabled'] && !$config['web_show_disabled']) { continue; } $int_links[$new['port_id']] = $new['port_id']; $int_links_v4[$new['port_id']][] = $new['ipv4_network']; } } -- With Best Regards, Supun Rathnayake Lanka communication Services (Pvt) Ltd. 65C, Dharmapala Mawatha, Colombo 07. Sri Lanka. Tel: +94-11-2437545 http://www.lankacom.net [1] http://blog.lankacom.net [2] _______________________________________________ observium mailing list observium@observium.org <mailto:observium@observium.org> http://postman.memetic.org/cgi-bin/mailman/listinfo/observium [3] Links: ------ [1] http://www.lankacom.net [2] http://blog.lankacom.net [3] http://postman.memetic.org/cgi-bin/mailman/listinfo/observium _______________________________________________ observium mailing list observium@observium.org <mailto:observium@observium.org> http://postman.memetic.org/cgi-bin/mailman/listinfo/observium _______________________________________________ observium mailing list observium@observium.org <mailto:observium@observium.org> http://postman.memetic.org/cgi-bin/mailman/listinfo/observium-- Mike Stupalov http://observium.org/
observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
Heya,
Glad you're happy - I noted it in my to-do but did not look for the mailing list thread to reply it was implemented.
Be sure to give me a shout in case you see oddities. But I think it should be OK. :-)
Tom
On 11/04/2014 01:24 PM, Supun Rathnayake wrote:
Hi All,
The recent svn update below (r5928) solved my earlier request made sometime back, Thanks a lot guys !!!
Author: sid3windr Date: 2014-11-02 01:01:14 +0100 (Sun, 02 Nov 2014) New Revision: 5928
Modified: observium/trunk/html/includes/functions.inc.php observium/trunk/html/includes/print-interface.inc.php observium/trunk/includes/dbFacile.php observium/trunk/includes/defaults.inc.php observium/trunk/includes/definitions.inc.php observium/trunk/includes/discovery/ipv6-addresses.inc.php observium/trunk/includes/functions.inc.php Log: Medium: add ignore_common_subnet option, which allows you to specify (exact) subnets that should not be considered for the 'other ports on same subnet' displayed in the port listing
With Best Regards,
Supun Rathnayake
Lanka communication Services (Pvt) Ltd. 65C, Dharmapala Mawatha, Colombo 07. Sri Lanka. Tel: +94-11-2437545 http://www.lankacom.net On 01/09/2014 02:31 AM, Mike Stupalov wrote:
Hi,
yes, I was going to make this long ago. I will make this soon.
Mike.
On Tue, Jan 7, 2014 at 3:25 PM, Adam Armstrong <adama@memetic.org mailto:adama@memetic.org> wrote:
Hi, I think we would prefer to do something like "connected to 21 devices" with a mouseover popup containing the list, when there are more than 5 or so devices. adam. On 2014-01-07 10:12, Supun Rathnayake wrote: Hi All, Please find the annexed screenshot of part of the interface, depicting this case. With Best Regards, Supun Rathnayake Lanka communication Services (Pvt) Ltd. 65C, Dharmapala Mawatha, Colombo 07. Sri Lanka. Tel: +94-11-2437545 http://www.lankacom.net [1] http://blog.lankacom.net [2] On 01/06/2014 06:35 PM, Supun Rathnayake wrote: Hi All, I have a small suggestion regarding the info displayed together with each interface under 'Port' => 'Detail' . There we noticed the observium displays all other devices on the same subnet from other devices at the last column of each interface irrespective of whether they are real IPs ( internet routable ) or Private IP addresses ( defined in RFC 1918 ). Although this feature is really good, we feel that if there is an option to exclude certain IP subnets from this selection, specially the private IP addresses it would make sense because we found there are lot of unrelated interfaces are getting listed ( about 50 items ) under this merely because of the fact that they are having the same IP addresses/subnets but which are completely different and isolated device interfaces in other VPNs which is common in IP VPN setups. We found the location where this logic is programmed, and we can easily changed the SQL query to accommodate this as follows ( `IPV4_ADDRESS` NOT LIKE '192.168.% ETC. ) shown below But it would be elegant if these excluding subnets could be defined as a config parameter and filter them here. This is just a suggestion, there may be better ideas out there with you guys What do you all think ? /opt/observium/html/includes/print-interface.inc.php : if ($port_details) { // SHOW WHICH OTHER DEVICES ARE ON THE SAME SUBNET AS THIS INTERFACE foreach (dbFetchRows("SELECT `ipv4_network_id` FROM `ipv4_addresses` WHERE `port_id` = ? AND `ipv4_address` NOT LIKE '127.%' AND `IPV4_ADDRESS` NOT LIKE '192.168.%'", array($port['port_id'])) as $net) { $sql = "SELECT N.*, P.`port_id`, P.`device_id` FROM `ipv4_addresses` AS A, `ipv4_networks` AS N, `ports` AS P WHERE A.`port_id` = P.`port_id` AND P.`device_id` != ? AND A.`ipv4_network_id` = ? AND N.`ipv4_network_id` = A.`ipv4_network_id` AND P.`ifAdminStatus` = 'up'"; $params = array($device['device_id'], $net['ipv4_network_id']); foreach (dbFetchRows($sql, $params) AS $new) { if ($cache['devices']['id'][$new['device_id']]['disabled'] && !$config['web_show_disabled']) { continue; } $int_links[$new['port_id']] = $new['port_id']; $int_links_v4[$new['port_id']][] = $new['ipv4_network']; } } -- With Best Regards, Supun Rathnayake Lanka communication Services (Pvt) Ltd. 65C, Dharmapala Mawatha, Colombo 07. Sri Lanka. Tel: +94-11-2437545 http://www.lankacom.net [1] http://blog.lankacom.net [2] _______________________________________________ observium mailing list observium@observium.org <mailto:observium@observium.org> http://postman.memetic.org/cgi-bin/mailman/listinfo/observium [3] Links: ------ [1] http://www.lankacom.net [2] http://blog.lankacom.net [3] http://postman.memetic.org/cgi-bin/mailman/listinfo/observium _______________________________________________ observium mailing list observium@observium.org <mailto:observium@observium.org> http://postman.memetic.org/cgi-bin/mailman/listinfo/observium _______________________________________________ observium mailing list observium@observium.org <mailto:observium@observium.org> http://postman.memetic.org/cgi-bin/mailman/listinfo/observium-- Mike Stupalov http://observium.org/
observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
Hi Tom,
Thanks a lot, sure we'll let you know if there is anything :-)
Thanks, Supun.
On 11/04/2014 06:51 PM, Tom Laermans wrote:
Heya,
Glad you're happy - I noted it in my to-do but did not look for the mailing list thread to reply it was implemented.
Be sure to give me a shout in case you see oddities. But I think it should be OK. :-)
Tom
On 11/04/2014 01:24 PM, Supun Rathnayake wrote:
Hi All,
The recent svn update below (r5928) solved my earlier request made sometime back, Thanks a lot guys !!!
Author: sid3windr Date: 2014-11-02 01:01:14 +0100 (Sun, 02 Nov 2014) New Revision: 5928
Modified: observium/trunk/html/includes/functions.inc.php observium/trunk/html/includes/print-interface.inc.php observium/trunk/includes/dbFacile.php observium/trunk/includes/defaults.inc.php observium/trunk/includes/definitions.inc.php observium/trunk/includes/discovery/ipv6-addresses.inc.php observium/trunk/includes/functions.inc.php Log: Medium: add ignore_common_subnet option, which allows you to specify (exact) subnets that should not be considered for the 'other ports on same subnet' displayed in the port listing
With Best Regards,
Supun Rathnayake
Lanka communication Services (Pvt) Ltd. 65C, Dharmapala Mawatha, Colombo 07. Sri Lanka. Tel: +94-11-2437545 http://www.lankacom.net On 01/09/2014 02:31 AM, Mike Stupalov wrote:
Hi,
yes, I was going to make this long ago. I will make this soon.
Mike.
On Tue, Jan 7, 2014 at 3:25 PM, Adam Armstrong <adama@memetic.org mailto:adama@memetic.org> wrote:
Hi, I think we would prefer to do something like "connected to 21 devices" with a mouseover popup containing the list, when there are more than 5 or so devices. adam. On 2014-01-07 10:12, Supun Rathnayake wrote: Hi All, Please find the annexed screenshot of part of the interface, depicting this case. With Best Regards, Supun Rathnayake Lanka communication Services (Pvt) Ltd. 65C, Dharmapala Mawatha, Colombo 07. Sri Lanka. Tel: +94-11-2437545 http://www.lankacom.net [1] http://blog.lankacom.net [2] On 01/06/2014 06:35 PM, Supun Rathnayake wrote: Hi All, I have a small suggestion regarding the info displayed together with each interface under 'Port' => 'Detail' . There we noticed the observium displays all other devices on the same subnet from other devices at the last column of each interface irrespective of whether they are real IPs ( internet routable ) or Private IP addresses ( defined in RFC 1918 ). Although this feature is really good, we feel that if there is an option to exclude certain IP subnets from this selection, specially the private IP addresses it would make sense because we found there are lot of unrelated interfaces are getting listed ( about 50 items ) under this merely because of the fact that they are having the same IP addresses/subnets but which are completely different and isolated device interfaces in other VPNs which is common in IP VPN setups. We found the location where this logic is programmed, and we can easily changed the SQL query to accommodate this as follows ( `IPV4_ADDRESS` NOT LIKE '192.168.% ETC. ) shown below But it would be elegant if these excluding subnets could be defined as a config parameter and filter them here. This is just a suggestion, there may be better ideas out there with you guys What do you all think ? /opt/observium/html/includes/print-interface.inc.php : if ($port_details) { // SHOW WHICH OTHER DEVICES ARE ON THE SAME SUBNET AS THIS INTERFACE foreach (dbFetchRows("SELECT `ipv4_network_id` FROM `ipv4_addresses` WHERE `port_id` = ? AND `ipv4_address` NOT LIKE '127.%' AND `IPV4_ADDRESS` NOT LIKE '192.168.%'", array($port['port_id'])) as $net) { $sql = "SELECT N.*, P.`port_id`, P.`device_id` FROM `ipv4_addresses` AS A, `ipv4_networks` AS N, `ports` AS P WHERE A.`port_id` = P.`port_id` AND P.`device_id` != ? AND A.`ipv4_network_id` = ? AND N.`ipv4_network_id` = A.`ipv4_network_id` AND P.`ifAdminStatus` = 'up'"; $params = array($device['device_id'], $net['ipv4_network_id']); foreach (dbFetchRows($sql, $params) AS $new) { if ($cache['devices']['id'][$new['device_id']]['disabled'] && !$config['web_show_disabled']) { continue; } $int_links[$new['port_id']] = $new['port_id']; $int_links_v4[$new['port_id']][] = $new['ipv4_network']; } } -- With Best Regards, Supun Rathnayake Lanka communication Services (Pvt) Ltd. 65C, Dharmapala Mawatha, Colombo 07. Sri Lanka. Tel: +94-11-2437545 http://www.lankacom.net [1] http://blog.lankacom.net [2] _______________________________________________ observium mailing list observium@observium.org <mailto:observium@observium.org> http://postman.memetic.org/cgi-bin/mailman/listinfo/observium [3] Links: ------ [1] http://www.lankacom.net [2] http://blog.lankacom.net [3] http://postman.memetic.org/cgi-bin/mailman/listinfo/observium _______________________________________________ observium mailing list observium@observium.org <mailto:observium@observium.org> http://postman.memetic.org/cgi-bin/mailman/listinfo/observium _______________________________________________ observium mailing list observium@observium.org <mailto:observium@observium.org> http://postman.memetic.org/cgi-bin/mailman/listinfo/observium-- Mike Stupalov http://observium.org/
observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
participants (4)
-
Adam Armstrong -
Mike Stupalov -
Supun Rathnayake -
Tom Laermans