![](https://secure.gravatar.com/avatar/5a3ba702de575cdf02834e4b73b64993.jpg?s=120&d=mm&r=g)
Hi
The link names for ppp interfaces on the mikrotik routers are wrapped in <> i.e. <pptp-david> this seems to be causing some issues on the website.
For example: <span class="entity-title"> <a href="device/device=28/tab=port/port=1462/" class="entity-popup " data-eid="1462" data-etype="port" data-hasqtip="1"><pptp-david></pptp-david></a> </span>
Regards — David Peall
![](https://secure.gravatar.com/avatar/5a3ba702de575cdf02834e4b73b64993.jpg?s=120&d=mm&r=g)
Hi
I’m not sure if this is the right way but I came right with this:
Index: includes/rewrites.php =================================================================== --- includes/rewrites.php (revision 5299) +++ includes/rewrites.php (working copy) @@ -268,6 +268,7 @@ $port['label'] = $port['label'] . " " . $port['ifIndex']; } } + $port['label'] = htmlentities($port['label']);
// Set entity variables for use by code which uses entities
Regards — David Peall
On 15 Apr 2014, at 12:24 PM, David Peall david@dnservices.co.za wrote:
Hi
The link names for ppp interfaces on the mikrotik routers are wrapped in <> i.e. <pptp-david> this seems to be causing some issues on the website.
For example:
<span class="entity-title"> <a href="device/device=28/tab=port/port=1462/" class="entity-popup " data-eid="1462" data-etype="port" data-hasqtip="1"><pptp-david></pptp-david></a> </span>
Regards — David Peall_______________________________________________ observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
![](https://secure.gravatar.com/avatar/21caf0a08d095be7196a1648d20942be.jpg?s=120&d=mm&r=g)
Hi David,
That is the right way indeed.
I will apply later (and probably htmlentities() some more fields).
Thanks, Tom
On 04/15/2014 02:48 PM, David Peall wrote:
Hi
I'm not sure if this is the right way but I came right with this:
Index: includes/rewrites.php
--- includes/rewrites.php (revision 5299) +++ includes/rewrites.php (working copy) @@ -268,6 +268,7 @@ $port['label'] = $port['label'] . " " . $port['ifIndex']; } }
$port['label'] = htmlentities($port['label']);
// Set entity variables for use by code which uses entities
Regards
David Peall
On 15 Apr 2014, at 12:24 PM, David Peall david@dnservices.co.za wrote:
Hi
The link names for ppp interfaces on the mikrotik routers are wrapped in <> i.e. <pptp-david> this seems to be causing some issues on the website.
For example:
<span class="entity-title"> <a href="device/device=28/tab=port/port=1462/" class="entity-popup " data-eid="1462" data-etype="port" data-hasqtip="1"><pptp-david></pptp-david></a> </span>
Regards
David Peall_______________________________________________ observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
![](https://secure.gravatar.com/avatar/21caf0a08d095be7196a1648d20942be.jpg?s=120&d=mm&r=g)
Hi David,
Mike committed code in r5312 that should fix this in a better way, can you confirm?
Tom
On 04/15/2014 03:11 PM, Tom Laermans wrote:
Hi David,
That is the right way indeed.
I will apply later (and probably htmlentities() some more fields).
Thanks, Tom
On 04/15/2014 02:48 PM, David Peall wrote:
Hi
I'm not sure if this is the right way but I came right with this:
Index: includes/rewrites.php
--- includes/rewrites.php (revision 5299) +++ includes/rewrites.php (working copy) @@ -268,6 +268,7 @@ $port['label'] = $port['label'] . " " . $port['ifIndex']; } }
$port['label'] = htmlentities($port['label']);
// Set entity variables for use by code which uses entities
Regards
David Peall
On 15 Apr 2014, at 12:24 PM, David Pealldavid@dnservices.co.za wrote:
Hi
The link names for ppp interfaces on the mikrotik routers are wrapped in <> i.e. <pptp-david> this seems to be causing some issues on the website.
For example:
<span class="entity-title"> <a href="device/device=28/tab=port/port=1462/" class="entity-popup " data-eid="1462" data-etype="port" data-hasqtip="1"><pptp-david></pptp-david></a> </span>
Regards
David Peall_______________________________________________ observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
participants (2)
-
David Peall
-
Tom Laermans