FreeBSD port update / "red" draw errors
As discussed back in June — http://comments.gmane.org/gmane.network.observium.general/10286 - this issue also affects FreeBSD.
Mathieu Arnold contributed a fix (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207057) which, together with a few other small patches & cleanups has been merged into the FreeBSD ports collection a few hours ago.
May be an idea to apply this patch (below) to HEAD; I suspect there is a similar issue in generic_multi_data_separated.
Dw
diff --git a/net-mgmt/observium/files/patch-html_includes_graphs_generic__multi__bits__separated.inc.php b/net-mgmt/observium/files/patch-html_includes_graphs_generic__multi__bits__separated.inc.php new file mode 100644 index 0000000..b6054c8 --- /dev/null +++ b/net-mgmt/observium/files/patch-html_includes_graphs_generic__multi__bits__separated.inc.php @@ -0,0 +1,27 @@ +--- html/includes/graphs/generic_multi_bits_separated.inc.php.orig 2016-01-15 08:37:56 UTC ++++ html/includes/graphs/generic_multi_bits_separated.inc.php +@@ -76,13 +76,13 @@ foreach ($rrd_list as $rrd) + $rrd_options .= " VDEF:totout".$i."=outB".$i.",TOTAL"; + $rrd_options .= " VDEF:tot".$i."=octets".$i.",TOTAL"; + +- if ($i) { $stack="STACK"; } ++ if ($i) { $stack=":STACK"; } + + if ($vars['line_graph']) + { + $rrd_options .= " LINE1.25:inB".$i."#" . $colour_in . ":'" . $descr . "'"; + } else { +- $rrd_options .= " AREA:inB".$i."#" . $colour_in . ":'" . $descr . "':$stack"; ++ $rrd_options .= " AREA:inB".$i."#" . $colour_in . ":'" . $descr . "'$stack"; + } + $rrd_options .= " GPRINT:inB".$i.":LAST:%6.2lf%s$units"; + $rrd_options .= " GPRINT:inB".$i.":AVERAGE:%6.2lf%s$units"; +@@ -97,7 +97,7 @@ foreach ($rrd_list as $rrd) + $rrd_options .= " 'LINE1.25:outB".$i."_neg#" . $colour_out . ":" . $descr_out . "'"; + } else { + $rrd_options .= " 'HRULE:0#" . $colour_out.":".$descr_out."'"; +- $rrd_optionsb .= " 'AREA:outB".$i."_neg#" . $colour_out . "::$stack'"; ++ $rrd_optionsb .= " 'AREA:outB".$i."_neg#" . $colour_out . ":$stack'"; + } + $rrd_options .= " GPRINT:outB".$i.":LAST:%6.2lf%s$units"; + $rrd_options .= " GPRINT:outB".$i.":AVERAGE:%6.2lf%s$units”;
Hi,
this issue already fixed in Pro Edition since r7545.
On 10.02.16 12:57, Dirk-Willem van Gulik wrote:
As discussed back in June — http://comments.gmane.org/gmane.network.observium.general/10286 - this issue also affects FreeBSD.
Mathieu Arnold contributed a fix (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207057) which, together with a few other small patches & cleanups has been merged into the FreeBSD ports collection a few hours ago.
May be an idea to apply this patch (below) to HEAD; I suspect there is a similar issue in generic_multi_data_separated.
Dw
diff --git a/net-mgmt/observium/files/patch-html_includes_graphs_generic__multi__bits__separated.inc.php b/net-mgmt/observium/files/patch-html_includes_graphs_generic__multi__bits__separated.inc.php new file mode 100644 index 0000000..b6054c8 --- /dev/null +++ b/net-mgmt/observium/files/patch-html_includes_graphs_generic__multi__bits__separated.inc.php @@ -0,0 +1,27 @@ +--- html/includes/graphs/generic_multi_bits_separated.inc.php.orig 2016-01-15 08:37:56 UTC ++++ html/includes/graphs/generic_multi_bits_separated.inc.php +@@ -76,13 +76,13 @@ foreach ($rrd_list as $rrd)
- $rrd_options .= " VDEF:totout".$i."=outB".$i.",TOTAL";
- $rrd_options .= " VDEF:tot".$i."=octets".$i.",TOTAL";
+- if ($i) { $stack="STACK"; } ++ if ($i) { $stack=":STACK"; }
- if ($vars['line_graph'])
- {
$rrd_options .= " LINE1.25:inB".$i."#" . $colour_in . ":'" . $descr . "'";- } else {
+- $rrd_options .= " AREA:inB".$i."#" . $colour_in . ":'" . $descr . "':$stack"; ++ $rrd_options .= " AREA:inB".$i."#" . $colour_in . ":'" . $descr . "'$stack";
- }
- $rrd_options .= " GPRINT:inB".$i.":LAST:%6.2lf%s$units";
- $rrd_options .= " GPRINT:inB".$i.":AVERAGE:%6.2lf%s$units";
+@@ -97,7 +97,7 @@ foreach ($rrd_list as $rrd)
$rrd_options .= " 'LINE1.25:outB".$i."_neg#" . $colour_out . ":" . $descr_out . "'";- } else {
$rrd_options .= " 'HRULE:0#" . $colour_out.":".$descr_out."'";+- $rrd_optionsb .= " 'AREA:outB".$i."_neg#" . $colour_out . "::$stack'"; ++ $rrd_optionsb .= " 'AREA:outB".$i."_neg#" . $colour_out . ":$stack'";
- }
- $rrd_options .= " GPRINT:outB".$i.":LAST:%6.2lf%s$units";
- $rrd_options .= " GPRINT:outB".$i.":AVERAGE:%6.2lf%s$units”;
observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
It's entirely possible that we'll release another CE this month to roll up a bunch of fixes, so that we'll be happier with CE's 6 month release cycle.
This fix is one of them :)
adam. On 10/02/2016 11:09:14, Mike Stupalov mike@observium.org wrote: Hi,
this issue already fixed in Pro Edition since r7545.
On 10.02.16 12:57, Dirk-Willem van Gulik wrote:
As discussed back in June — http://comments.gmane.org/gmane.network.observium.general/10286 - this issue also affects FreeBSD.
Mathieu Arnold contributed a fix (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207057) which, together with a few other small patches & cleanups has been merged into the FreeBSD ports collection a few hours ago.
May be an idea to apply this patch (below) to HEAD; I suspect there is a similar issue in generic_multi_data_separated.
Dw
diff --git a/net-mgmt/observium/files/patch-html_includes_graphs_generic__multi__bits__separated.inc.php b/net-mgmt/observium/files/patch-html_includes_graphs_generic__multi__bits__separated.inc.php new file mode 100644 index 0000000..b6054c8 --- /dev/null +++ b/net-mgmt/observium/files/patch-html_includes_graphs_generic__multi__bits__separated.inc.php @@ -0,0 +1,27 @@ +--- html/includes/graphs/generic_multi_bits_separated.inc.php.orig 2016-01-15 08:37:56 UTC ++++ html/includes/graphs/generic_multi_bits_separated.inc.php +@@ -76,13 +76,13 @@ foreach ($rrd_list as $rrd)
- $rrd_options .= " VDEF:totout".$i."=outB".$i.",TOTAL";
- $rrd_options .= " VDEF:tot".$i."=octets".$i.",TOTAL";
+- if ($i) { $stack="STACK"; } ++ if ($i) { $stack=":STACK"; }
- if ($vars['line_graph'])
- {
- $rrd_options .= " LINE1.25:inB".$i."#" . $colour_in . ":'" . $descr . "'";
- } else {
+- $rrd_options .= " AREA:inB".$i."#" . $colour_in . ":'" . $descr . "':$stack"; ++ $rrd_options .= " AREA:inB".$i."#" . $colour_in . ":'" . $descr . "'$stack";
- }
- $rrd_options .= " GPRINT:inB".$i.":LAST:%6.2lf%s$units";
- $rrd_options .= " GPRINT:inB".$i.":AVERAGE:%6.2lf%s$units";
+@@ -97,7 +97,7 @@ foreach ($rrd_list as $rrd)
- $rrd_options .= " 'LINE1.25:outB".$i."_neg#" . $colour_out . ":" . $descr_out . "'";
- } else {
- $rrd_options .= " 'HRULE:0#" . $colour_out.":".$descr_out."'";
+- $rrd_optionsb .= " 'AREA:outB".$i."_neg#" . $colour_out . "::$stack'"; ++ $rrd_optionsb .= " 'AREA:outB".$i."_neg#" . $colour_out . ":$stack'";
- }
- $rrd_options .= " GPRINT:outB".$i.":LAST:%6.2lf%s$units";
- $rrd_options .= " GPRINT:outB".$i.":AVERAGE:%6.2lf%s$units”;
observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
-- Mike Stupalov http://observium.org
_______________________________________________ observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
Adam, another CE will be greatly appreciated, I have that error too on debian 8.2... and I spent the day trying to figure out why my cisco 3950s has no neighbors and map menu.
On 2/10/2016 7:55 AM, Adam Armstrong wrote:
It's entirely possible that we'll release another CE this month to roll up a bunch of fixes, so that we'll be happier with CE's 6 month release cycle.
This fix is one of them :)
adam.
On 10/02/2016 11:09:14, Mike Stupalov mike@observium.org wrote:
Hi,
this issue already fixed in Pro Edition since r7545.
On 10.02.16 12:57, Dirk-Willem van Gulik wrote:
As discussed back in June —
http://comments.gmane.org/gmane.network.observium.general/10286 - this issue also affects FreeBSD.
Mathieu Arnold contributed a fix
(https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=207057) which, together with a few other small
patches & cleanups has been merged into the FreeBSD ports
collection a few hours ago.
May be an idea to apply this patch (below) to HEAD; I suspect there
is a similar issue in generic_multi_data_separated.
Dw
diff --git
a/net-mgmt/observium/files/patch-html_includes_graphs_generic__multi__bits__separated.inc.php b/net-mgmt/observium/files/patch-html_includes_graphs_generic__multi__bits__separated.inc.php
new file mode 100644 index 0000000..b6054c8 --- /dev/null +++
b/net-mgmt/observium/files/patch-html_includes_graphs_generic__multi__bits__separated.inc.php
@@ -0,0 +1,27 @@ +--- html/includes/graphs/generic_multi_bits_separated.inc.php.orig
2016-01-15 08:37:56 UTC
++++ html/includes/graphs/generic_multi_bits_separated.inc.php +@@ -76,13 +76,13 @@ foreach ($rrd_list as $rrd)
- $rrd_options .= " VDEF:totout".$i."=outB".$i.",TOTAL";
- $rrd_options .= " VDEF:tot".$i."=octets".$i.",TOTAL";
+- if ($i) { $stack="STACK"; } ++ if ($i) { $stack=":STACK"; }
- if ($vars['line_graph'])
- {
- $rrd_options .= " LINE1.25:inB".$i."#" . $colour_in . ":'" .
$descr . "'";
- } else {
+- $rrd_options .= " AREA:inB".$i."#" . $colour_in . ":'" . $descr
. "':$stack";
++ $rrd_options .= " AREA:inB".$i."#" . $colour_in . ":'" . $descr
. "'$stack";
- }
- $rrd_options .= " GPRINT:inB".$i.":LAST:%6.2lf%s$units";
- $rrd_options .= " GPRINT:inB".$i.":AVERAGE:%6.2lf%s$units";
+@@ -97,7 +97,7 @@ foreach ($rrd_list as $rrd)
- $rrd_options .= " 'LINE1.25:outB".$i."_neg#" . $colour_out . ":"
. $descr_out . "'";
- } else {
- $rrd_options .= " 'HRULE:0#" . $colour_out.":".$descr_out."'";
+- $rrd_optionsb .= " 'AREA:outB".$i."_neg#" . $colour_out .
"::$stack'";
++ $rrd_optionsb .= " 'AREA:outB".$i."_neg#" . $colour_out .
":$stack'";
- }
- $rrd_options .= " GPRINT:outB".$i.":LAST:%6.2lf%s$units";
- $rrd_options .= " GPRINT:outB".$i.":AVERAGE:%6.2lf%s$units”;
observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
-- Mike Stupalov http://observium.org
observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
observium mailing list observium@observium.org http://postman.memetic.org/cgi-bin/mailman/listinfo/observium
participants (4)
-
Adam Armstrong -
Dirk-Willem van Gulik -
greg lambert -
Mike Stupalov