- observium - lists.observium.org

Re: [Observium] [patch] - allow the ignoring of ports/interfaces
by Adam Armstrong 03 Sep '10

03 Sep '10

On 03/09/2010 15:03, Dirk-Willem van Gulik wrote: > > Op 3 sep 2010, om 15:55 heeft Adam Armstrong het volgende geschreven: > >> On 03/09/2010 14:52, Dirk-Willem van Gulik wrote: >>> >>> Op 3 sep 2010, om 15:33 heeft Adam Armstrong het volgende geschreven: >>> >>>> It needs a bit of cleaning up (the table and stuff is kinda ugly), >>>> but it's useful :) >>>> >>> Aye - agreed. I took it from the other scripts in that section - as >>> I was unsure how much freedom I had to 'fix' that. >>> >>> Dw. >>> >> We generally don't mind people rewriting things, so long as the code >> retains a level of simplicity that means most people can work on it >> (i.e. no OOP or complex structures), as most of us aren't programmers >> primarily :) > > Ok. > >> There is a lot of very old and dirty code which should be rewritten, > > Yes - and a lot of security/injection problems. I've fixed about a trillion, feel free to fix any others you find. We have shortened mysqlrealescapestring to mres() for using variables in MySQL. >> so it's not always a good idea to look at existing stuff for >> examples. Personally, I can't write user-interaction stuff to save my >> life, so it's usually terrible. > > Ok. Meanwhile - would you mind me doing a bit of a clean (like the > patch for freebsd/darwin/solaris) of a few days ago ? Or is that not > something you are willing to merge in ? In which case it is easier for > me to ignore patch cleanup. Feel free to clean whatever up. It's often better to ask others what they think of changes, as there are quite a few others with ideas on how we should change things. Most discussion is on the IRC channel on Freenode. Some of our primary goals are ease and intuitiveness of UI (we quite often won't implement things until we know exactly how it should look in the web interface), and enforcement of good practice in SPs (we dislike implementing things to work around the lazy or bad practices of others, as it only helps to make our own staff lazy!) > My private agenda is a bit if 'ignore' flags (disks, interfaces) where > needed, disk thresholds, SNMPv3, netgear switches (see patch), bit > more power discovery on APC and perhaps an 'aggregate/stack bandwidht' > display for switches as an option in the all-devices-graph-popup - as > for a lot of swtiches uptime/cpu displays make little sense. We certainly need more manual ignores. I also think we perhaps shouldn't delete things so readily, rather mark them removed but retain data and settings, incase they spontaneously reappear. adam.

1 0

[patch] allow the disabling of graphs in the hostbox
by Dirk-Willem van Gulik 03 Sep '10

03 Sep '10

Minor patch (with example for Netgear) to allow the wholesale/hierachical disabling of the graphs in the host box popup. Which can be useful for certain devices which may not have a natural/default graph to always display (obviously - this really needs to be come a 'tick-if-you-want-this-graph in the summary display). Thanks, Dw Index: html/includes/functions.inc.php =================================================================== --- html/includes/functions.inc.php (revision 1697) +++ html/includes/functions.inc.php (working copy) @@ -36,7 +36,7 @@ # if (isset($device['location'])) { $contents .= "" . htmlentities($device['location'])."<br />"; } - foreach ($graphs as $entry) + if (!isset($graphs['disabled'])) foreach ($graphs as $entry) { $graph = $entry['graph']; $graphhead = $entry['text']; Index: includes/static-config.php =================================================================== --- includes/static-config.php (revision 1697) +++ includes/static-config.php (working copy) @@ -346,6 +346,12 @@ $config['os'][$os]['type'] = "network"; $config['os'][$os]['icon'] = "dlink"; +$os = "netgear"; +$config['os'][$os]['text'] = "Netgear Equipment"; +$config['os'][$os]['type'] = "network"; +$config['os'][$os]['icon'] = "netgear"; +$config['os'][$os]['over'][disabled] = 1; + $os = "dlinkap"; $config['os'][$os]['text'] = "D-Link Access Point"; $config['os'][$os]['type'] = "network";

1 0

[patch] - allow the ignoring of ports/interfaces
by Dirk-Willem van Gulik 03 Sep '10

03 Sep '10

Below is a small patch; it adds an extra option on the device Setting menu; which slows a list of ports - and allows the editing of the ignore flag. This is useful on switches which are partially populated - and also makes the overview page a lot more useful. Dw. Index: html/includes/port-edit.inc.php =================================================================== --- html/includes/port-edit.inc.php (revision 0) +++ html/includes/port-edit.inc.php (revision 0) @@ -0,0 +1,49 @@ +<?php + +# enable/disable ports/interfaces on devices. +# + +$device_id=intval($_POST['device']); +$rows_updated = 0; + +foreach ($_POST as $key => $val) { + if (strncmp($key,"oldval_",7) == 0) { + + # Interface identifier passed as part of the field name + # + $interface_id = intval(substr($key,7)); + + $oldval = intval($val) ? 1 : 0; + $newval = $_POST['ignore_'.$interface_id] ? 1 : 0; + + # As checkboxes are not posted when unset - we effectively need to do a diff to work + # out a set->unset case. + # + if ($oldval == $newval) + continue; + + if (!mysql_query('UPDATE `ports` SET `ignore`='.$newval.' WHERE `device_id`='.$device_id.' AND `interface_id`='.$interface_id)) + $n = -1; + else + $n = mysql_affected_rows(); + + if ($n <0) { + $rows_updated = -1; + break; + }; + $rows_updated += $n; + }; +}; + + if($rows_updated > 0) { + $update_message = $rows_updated . " Device record updated."; + $updated = 1; + } elseif ($rows_updated = '-1') { + $update_message = "Device record unchanged. No update necessary."; + $updated = -1; + } else { + $update_message = "Device record update error."; + $updated = 0; + } + +?> Property changes on: html/includes/port-edit.inc.php ___________________________________________________________________ Added: svn:executable + * Index: html/pages/device/edit.inc.php =================================================================== --- html/pages/device/edit.inc.php (revision 1696) +++ html/pages/device/edit.inc.php (working copy) @@ -6,6 +6,7 @@ $panes = array('device' => 'Device Settings', + 'ports' => 'Port Settings', 'apps' => 'Applications', 'services' => 'Services'); Index: html/pages/device/edit/ports.inc.php =================================================================== --- html/pages/device/edit/ports.inc.php (revision 0) +++ html/pages/device/edit/ports.inc.php (revision 0) @@ -0,0 +1,51 @@ +<?php + +echo('<div style="padding: 10px;">'); + +if($_POST['ignoreport']) { + if($_SESSION['userlevel'] == '10') { + include("includes/port-edit.inc.php"); + } +} + + +if($updated && $update_message) { + print_message($update_message); +} elseif ($update_message) { + print_error($update_message); +} + +echo("<div style='float: left;'> +<form id='ignoreport' name='ignoreport' method='post' action=''> + <input type=hidden name='ignoreport' value='yes'> + <input type=hidden name=device value='".$device['device_id']."'> +<table> +<tr><th>Port</th><th>ifDescr</th><th>ifAdminStatus</th><th>ifOperStatus</th><th>Ignore</th></tr>"); + +$query = mysql_query("SELECT * FROM `ports` WHERE device_id='".$device['device_id']."' ORDER BY `ifIndex` "); +while($device = mysql_fetch_array($query)) { + echo "<tr>"; + echo "<td align=right>". $device['ifIndex']."</td>"; + echo "<td align=left>".$device['ifDescr'] . "</td>"; + echo "<td align=right>". $device['ifAdminStatus']."</td>"; + + # Mark interfaces which are down yet not ignored, or up - yet ignored - as to draw the attention + # to a possible problem. + # + $outofsync = ($device['ignore'] == ($device['ifOperStatus'] == 'down' ? 1 : 0)) ? "" : "class=red"; + + echo "<td align=right><span ".$outofsync.">". $device['ifOperStatus']."</span></td>"; + + echo "<td>"; + echo "<input type=checkbox name='ignore_".$device['interface_id']."'".($device['ignore'] ? 'checked' : '').">"; + echo "<input type=hidden name='oldval_".$device['interface_id']."' value=".($device['ignore'] ? 1 : 0).">"; + echo "</td>"; + echo "</tr>"; +} + +echo('<tr><td></td><td></td><td></td><td></td><td><input type="submit" value="Save"></td></tr>'); +echo('</table>'); +echo('</form>'); +echo('</div>'); + +?>

3 4

no graphs after update to revision 1665
by Dario Calamai 11 Aug '10

11 Aug '10

Hi! I upgraded to revision 1665 and I see alert in database-update.sql " ## Change port rrds ". Now all graphs work fine for all devices but in - Customers view (all graphs are blank) - Vlan view (Bits | Packets | NU Packets | Errors ) of any devices (with error: "Graph Template Missing") - L2TP, Transit, Peering, Peering + Transit and Core views only Total Graph are correctly displayed, all single interface graphs are missing (but same graphs in Device-Interface view are ok!) Dario -- http://www.playnet.it phone +39 055 3226622 - fax +39 055 3226444 Brain Technology s.p.a. AS 13284 - http://lg.playnet.it http://www.linkedin.com/in/dariocalamai

2 1

real uptime
by Pas 10 Aug '10

10 Aug '10

Hi, The snmp-mibs-downloader package turned out to be less painful than anticipated. However, I've noticed, that Observium doesn't uses the HOST-RESOURCES-MIB::hrSystemUptime.0 value for uptime, and instead uses the uptime of the management service. Is this a bug or a feature? Thanks, Pas

2 2

Trademark Dispute
by Adam Armstrong 10 Aug '10

10 Aug '10

Hi All, Just to keep you guys updated on the trademark dispute we had regarding the "Observer" name. Having changed to "Observium" we've since received this: http://alpha.memetic.org/~adama/observer-tm-b.pdf Silly, eh? Adam.

1 0

Distribution detection fails
by Pas 06 Aug '10

06 Aug '10

Hi! I've installed Observium (SVN), configured according to the Ubuntu SVN guide, added the extend line to snmpd.conf but Observium still sees my Debian server as a Generic one. I've tried deleting and adding it again. Any advice? Also, after adding a device Observium doesn't perform an auto-discovery, is this by design? Thanks, Pas

4 15

Project Name Change - Observium
by Adam Armstrong 17 Jul '10

17 Jul '10

Hi All, Due to a potential trademark conflict, we've changed the name of the project to Observium. The mailing lists, wiki, website, bug tracker and twitter feed have already been migrated and should work as normal. We're planning to release 0.10.7 soon, so urgent bug reports and feature requests in now please! :) Thanks, Adam.

1 0